Skip to content

[lazy] support init on cuda#4269

Merged
FrankLeeeee merged 3 commits into
hpcaitech:mainfrom
ver217:feature/lazy-cuda
Jul 19, 2023
Merged

[lazy] support init on cuda#4269
FrankLeeeee merged 3 commits into
hpcaitech:mainfrom
ver217:feature/lazy-cuda

Conversation

@ver217

@ver217 ver217 commented Jul 18, 2023

Copy link
Copy Markdown
Contributor

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@ver217
ver217 marked this pull request as ready for review July 18, 2023 06:57
@ver217 ver217 added the enhancement New feature or request label Jul 19, 2023
@ver217
ver217 requested a review from FrankLeeeee July 19, 2023 02:19
@github-actions

Copy link
Copy Markdown
Contributor

The code coverage for the changed files is 87%.

Click me to view the complete report
Name                                 Stmts   Miss  Cover
--------------------------------------------------------
colossalai/lazy/lazy_init.py           308     37    88%
tests/test_lazy/lazy_init_utils.py      72     14    81%
tests/test_lazy/test_models.py          14      1    93%
--------------------------------------------------------
TOTAL                                  394     52    87%

@FrankLeeeee FrankLeeeee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM!

@FrankLeeeee
FrankLeeeee merged commit fc5cef2 into hpcaitech:main Jul 19, 2023
@FrankLeeeee
FrankLeeeee deleted the feature/lazy-cuda branch July 19, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants