Make the cable_server_path configurable #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Swap the meta-options and the script tag insertion in the middleware to avoid relying on DOMContentLoaded for setting the configuration values * Introduce config.js to avoid a circular dependency (fixes a warning in rollup)
This allows users to reconfigure their mount path, e.g. to add a prefix to it. With this config, hotwired#60 could reconfigure the mount path to include the relative_url_root prefix.
jorgemanrubia
approved these changes
Jan 25, 2025
Member
jorgemanrubia
left a comment
There was a problem hiding this comment.
Great one, thanks @codergeek121
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option to make the cable_server path
/hotwire-sparkconfigurable. This could be used to fix #60. Apps that need to mount on a different path (e.g. because ofrelative_url_root, could just reconfigure the mount path for them)It also fixes a circular dependency warning in
main, by extracting aconfig.jsfile.