Inc nn agent - #7
Open
jmorzel wants to merge 4 commits into
Open
Conversation
hlfshell
requested changes
Jul 15, 2022
|
|
||
| def step(self, simulation: Simulation): | ||
| durations: List[float] = None | ||
| changes: List[float] = None |
Owner
There was a problem hiding this comment.
Why the changes on averaged_nn_agent at all?
| ) | ||
|
|
||
|
|
||
| # standard sigmoid activation function |
| return 1/(1+np.exp(-input)) | ||
|
|
||
|
|
||
| # Standard relu |
Owner
There was a problem hiding this comment.
Just import from activation_functions
| traci.trafficlight.setPhase(id, phase + 1) | ||
| else: | ||
| traci.trafficlight.setPhase(id, 0) | ||
|
|
Owner
There was a problem hiding this comment.
Excessive spacing - use a linter.
| "duration": duration, | ||
| "state": state | ||
| "state": state, | ||
| "cntr" : 0 |
Owner
There was a problem hiding this comment.
What's this do? Why is it shorthand?
hlfshell
reviewed
Jul 16, 2022
| phase = traci.trafficlight.getPhase(id) | ||
|
|
||
| # Hardcoded for Chicago 02 sim | ||
| if id == "J02" or id == "J05" or id == "J08" : |
Owner
There was a problem hiding this comment.
No no no - if you can't do it dynamically don't hardcode. Not acceptable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.