chore(dev) improve match scope visualization #3126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshgoebel
reviewed
Apr 12, 2021
this change trades vertical space to reclaim some horizontal space that was previously lost when inspecting the class structure of the emitted hljs highlight. As a bonus, it's slightly easier to see hierarchy between parent/child elements because the visible structure text is stacked / indented like a tree, rather than inline, like it was previously.
c01c76d to
74e499c
Compare
Contributor
Author
|
oh holup, I can fix all the slight alignment issues |
Member
|
I'll take a closer look later, I wonder though if we can re-line up the content a bit better with an offset or negative margin on the blocks? IE, if this was offset better... not a big deal, just wondering. |
Contributor
Author
|
Yup, just remembered about align-items: baseline.
|
Member
|
Damn. That's sharp. |
Contributor
Author
|
Updated! |
Contributor
Author
|
Here is how it looks on my silly Glimmer stuff |
NullVoxPopuli
commented
Apr 12, 2021
joshgoebel
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change trades vertical space to reclaim some horizontal space
that was previously lost when inspecting the class structure of the
emitted hljs highlight.
As a bonus, it's slightly easier to see hierarchy between parent/child
elements because the visible structure text is stacked / indented
like a tree, rather than inline, like it was previously.
Example here: https://hljs-glimmer.nullvoxpopuli.com/?debug=true
Checklist
no markup changes
CHANGES.md