Change the python/ directory related warnings to errors#1830
Merged
Conversation
Builds will now error if either: - The Python buildpack has been run multiple times in the same build. - An existing `.heroku/python/` directory is found in the app source for any other reason (e.g. accidentally committed to Git) This upgrades the warnings added in #1724 in December 2024 to errors. No feedback/concerns were raised in the GitHub issue linked from the warning: #1704 And Honeycomb data shows: - the number of apps hitting the warnings was minimal - in most cases, the builds hitting the warnings were failing already (eg due to broken `python/` directories having been committed to Git, and so turning the warning into an error will actually give them a better error message than before). Closes #1704. GUS-W-17309720.
7ca77c3 to
45053f5
Compare
runesoerensen
approved these changes
Jul 10, 2025
Merged
edmorley
added a commit
that referenced
this pull request
Jul 14, 2025
These are not set/used since #1830.
edmorley
added a commit
that referenced
this pull request
Jul 15, 2025
These are not set/used since #1830.
edmorley
added a commit
that referenced
this pull request
Jul 18, 2025
After #1830, the two `checks::warn_if_*` functions now error rather than warn, so the function names have been renamed to match the behaviour.
edmorley
added a commit
that referenced
this pull request
Jul 18, 2025
After #1830, the two `checks::warn_if_*` functions now error rather than warn, so the function names have been renamed so they don't mislead about their behaviour.
edmorley
added a commit
that referenced
this pull request
Jul 18, 2025
After #1830, the two `checks::warn_if_*` functions now error rather than warn, so the function names have been renamed so they don't mislead about their behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds will now error if either:
.heroku/python/directory is found in the app source for any other reason (e.g. accidentally committed to Git)This upgrades the warnings added in #1724 in December 2024 to errors.
No feedback/concerns were raised in the GitHub issue linked from the warning:
#1704
And Honeycomb data shows:
python/directories having been committed to Git, and so turning the warning into an error will actually give them a better error message than before).Closes #1704.
GUS-W-17309720.