fix: validate and preprocess version in FindSemVerInfo#139
Merged
yxxhero merged 1 commit intoAug 14, 2025
Merged
Conversation
Signed-off-by: yxxhero <aiopsclub@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the robustness and usability of the
FindSemVerInfoutility function by handling empty and non-prefixed version strings, and updates the related tests to reflect the new behavior.Enhancements to version string handling:
FindSemVerInfoinutil.goto return an error if the input version string is empty and to automatically add avprefix if it's missing before extracting the semantic version.Test updates:
util_test.goto expect a valid semver result when the version string does not start withv, reflecting the new logic inFindSemVerInfo.