Conversation
| return | ||
| // when sending configs we do not print any responses, as typically configs do not produce any output | ||
| if d.SendConfigsFromFile != "" { | ||
| _, err := driver.SendConfigsFromFile(d.SendConfigsFromFile) |
Contributor
There was a problem hiding this comment.
it might be worth it to actual assign the response object and check the Failed attribute (err... method in the case of multi response since I dont know how to do something like a python property in go 😀 ) as this may indicate that the config itself failed from the device perspective -- even if everything "worked" from a scrapli perspective. the Failed attribute is governed by the FailedWhenContains slice of strings -- if we see any of those substrings in the returned output (stuff like "% invalid input" and the like).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR adds support for
send-commands-from-filesend-configssend-configs-from-filedevice-level options
The idea is to allow pushing some config to the devices before scrpaligo has cfg support.
/cc @carlmontanari