fix: fix borked concurrency bits #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
thanks @carlmontanari ! I'll wait for @glspi to report back that it is all good before merging this |
Contributor
|
Yo, used this code on 100 devices multiple times in production no issues, thanks! |
Owner
|
thanks @carlmontanari and @glspi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@glspi is maybe testing this a bit more, but we realized we were uh... not very concurrent 🤣
tldr; the
resp := <- rChwas blocking on each device waiting for response. so just moved things around a bit and created a dummy object to send into channel so we can always have the device name bound to response even if things fail early (as in no scrapligo response object gets created because we send nil to the rCh).