Feat: add campaign creation automation by ItsAbhinavM · Pull Request #583 · hatnote/montage

ItsAbhinavM · 2026-06-15T18:45:56Z

Description

Fixes #582

This PR adds support for "Campaign Creation Request" on Montage. Creates new pages like /requests, /requests/new and requests/MNTG-6772.

Changes made:

Frontend

CampaignRequestform: A forms like page where the user adds the detail of campaign and submits it.
Campaignrequestdetail: Displays campaign details after submission
Campaignrequests: Page which displays all campaign requests details
adminService.js: Updated endpoints of campaign requests.

Backend

A new DAO CampaignRequestDAO has been made along with its helper functions on admin_endpoints.py. Each request will receive an ID like MNTG-xxxx ( MNTG - Monitoring ) so that it can be tracked. New endpoints also has been made supporting the feature.

/admin/campaign_requests
/admin/campaign_requests/validate_user
/admin/campaign_requests/<request_id>
/admin/campaign_requests/submit
/admin/campaign_requests/<request_id>/approve
/admin/campaign_requests/<request_id>/advise
/admin/campaign_requests/<request_id>/resubmit

UI Changes

status: ~~In progress, UI is and some UX additions are yet to be added~~ Completed

ItsAbhinavM · 2026-06-19T19:25:03Z

@lgelauff The PR is complete now, could you please review this and suggest changes if required

ItsAbhinavM · 2026-06-19T19:25:55Z

Please don't mind the changes in RoundEdit page as it came to satisfy the linting issues which appeared on the PR pipeline.

ItsAbhinavM · 2026-06-19T19:28:22Z

@lgelauff if you require the screen recording of this feature, please do tell. Since this is a relatively big PR screen recording of larger duration will not be supported in Github comment ( 10MB max ). I might have to upload the recording to my cloud which might take time.

lgelauff · 2026-06-19T20:23:06Z

@lgelauff if you require the screen recording of this feature, please do tell. Since this is a relatively big PR screen recording of larger duration will not be supported in Github comment ( 10MB max ). I might have to upload the recording to my cloud which might take time.

A recording would be super helpful. A few shorter ones would also help. Feel free to push the PR to montage-beta!

lgelauff

I'm not sure if I fully understand the design. I should have asked earlier, but it would be helpful if you can explain in the issue your big picture design. Especially try to make explicit the assumptions you're making, who's filling what out, and what happens before/after the request.

It seems some of your functions resemble some functionality elsewhere in the code, and make me wonder if we can reuse some.

My coding assistant was suggesting some more functional problems, but maybe it's more helpful to deal with this first.

lgelauff · 2026-06-20T20:43:01Z

+    meta: { requiresAuth: true }
+  },
+  {
+    path: '/requests/:requestId',


Is this different from request_id ?

Yes, this page is used for viewing the description of the request, its the campaignRequestDetail.vue page.

lgelauff · 2026-06-20T20:48:36Z

+    Lifecycle:  pending  ->  approved          (campaign_id is set)
+                         ->  needs_clarification  ->  pending  (resubmit)
+    """
+    __tablename__ = 'campaign_requests'


please include migration in tools/migrate_prod_db.sql

lgelauff · 2026-06-20T20:50:31Z

        qs = qs.order_by(Campaign.id)
        return qs.first()
+
+class CampaignRequestDAO(object):


Is this supposed to be the same as the earlier declared class?

Oh, I'm sorry this was a separate class which I had for debugging purpose, will remove them.

lgelauff · 2026-06-20T20:52:02Z

+        </cdx-button>
+      </router-link>
+    </div>
+    <!-- Add v-if="isSuperuser" clause for this div later -->


leftover todo?

lgelauff · 2026-06-20T20:52:24Z

+
+// const props = defineProps({
+//   isSuperuser: { type: Boolean, default: false }
+// })


debug code?

lgelauff · 2026-06-20T20:59:38Z

        self.rdb_session.add(flag)

+def _generate_request_id():
+    suffix = ''.join(random.choices(string.digits, k=4)) # MNTG - Monitoring


Please verify collision probability at expected rates.
Why do we need random?

lgelauff · 2026-06-20T21:01:25Z

+              </tr>
+            </thead>
+            <tbody>
+              <tr v-for="tz in COMMON_TIMEZONES" :key="tz.id">


Any thoughts on how we handle times elsewhere in Montage?

lgelauff · 2026-06-20T21:04:47Z

+        raise InvalidAction('username query parameter is required.')
+    return {'data': {'username': username, 'exists': _wikimedia_user_exists(username)}}
+
+def _wikimedia_user_exists(username):


Would we be able to reuse existing functionality?

lgelauff · 2026-06-20T21:15:06Z

+        users = resp.json().get('query', {}).get('users', [])
+        return bool(users) and 'missing' not in users[0]
+    except Exception:
+        return True 


This confuses me. Does that mean if there's an exception you'd accept anything?

I attempted for a fail-true approach, incase the API gets down, I think currently the exception is a bit too broad as it could handle any edge case. Will change it to make it specifically for RequestException

ItsAbhinavM · 2026-06-28T05:18:39Z

@lgelauff I've made the changes as per your review, here is the video snippet of the feature.

2026-06-28.10-39-16.1.mp4

ItsAbhinavM added 5 commits June 15, 2026 23:53

wip: add campaign creation automation

4eec4c9

refactor: improve codebase with codex and improve frontend interface

e12e8c3

feat: add multi juror support for campaign request and approve pipeline

4814aaa

fix: eslint corrections

b498091

chore: refactoring frontend for lint

891b630

lgelauff reviewed Jun 20, 2026

View reviewed changes

ItsAbhinavM added 2 commits June 26, 2026 16:00

fix: update isSuperUser to isMaintainer and round req_id logic

5b93c37

chore: fix linting for isMaintainer declaration

82b70c6

fix: no-requests text css

16bffe3

Uh oh!

Conversation

ItsAbhinavM commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes made:

Frontend

Backend

UI Changes

Uh oh!

ItsAbhinavM commented Jun 19, 2026

Uh oh!

ItsAbhinavM commented Jun 19, 2026

Uh oh!

ItsAbhinavM commented Jun 19, 2026

Uh oh!

lgelauff commented Jun 19, 2026

Uh oh!

lgelauff left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ItsAbhinavM commented Jun 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ItsAbhinavM commented Jun 15, 2026 •

edited

Loading