fix: load_partial_csv fallback in Google Sheet imports wraps response in DictReader - #546
Open
ayushshukla1807 wants to merge 1 commit into
Open
Conversation
ItsAbhinavM
reviewed
Jul 13, 2026
Collaborator
There was a problem hiding this comment.
Thanks for this @ayushshukla1807. This correctly fixes the resp issue with DictReader, but #517 also asks that the broad except (ValueError, TypeError ): around this fallback be removed so failures surface instead of being silently redirected to load_name_list. I think your other PR #521 handles both parts properly. @lgelauff I think we can close this PR. Appreciate you digging into this either way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #517.
The fallback path in
get_entries_from_gsheetcalledload_partial_csv(resp)passing the rawrequests.Responseobject directly. The function expects aDictReader(it immediately does[r["filename"] for r in dr]), so this always raised aTypeErrorand permanently fell through to the last-resort filename-splitting path.The TODO comment in the code even acknowledged this:
# TODO: load_partial_csv expects a dictreader, did this ever work?Fix: Wrap
resp.contentinBytesIOand pass it throughunicodecsv.DictReaderbefore callingload_partial_csv. The existingexcept (ValueError, TypeError)fallback is preserved for any subsequent failures.