fix: null-check rnd.name before slugify in download_results_csv#544
Open
ayushshukla1807 wants to merge 1 commit into
Open
Conversation
This was referenced Apr 30, 2026
Closed
ItsAbhinavM
approved these changes
Jul 21, 2026
Collaborator
There was a problem hiding this comment.
@ayushshukla1807 thank you for your contribution. Since you are trying to cover file naming issue with.replace(':', '-') I believe datetime.now().isoformat() would include microseconds which has .. It'd be good if you could cover that as well. The rest of the changes looks good. @lgelauff we can merge this if this is adequate for the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #542.
slugify(rnd.name, ...)raisesAttributeErrorifrnd.nameisNone. Added a null-guard with a sensible fallback (unnamed-round).Also replaced colons in
isoformat()output with dashes since colons in filenames cause issues on Windows/macOS when downloading the CSV.