Skip to content

Fixes #155 - #419

Closed
ayushshukla1807 wants to merge 5 commits into
hatnote:masterfrom
ayushshukla1807:fix-upload-date-from-first-version
Closed

Fixes #155 #419
ayushshukla1807 wants to merge 5 commits into
hatnote:masterfrom
ayushshukla1807:fix-upload-date-from-first-version

Conversation

@ayushshukla1807

@ayushshukla1807 ayushshukla1807 commented Mar 21, 2026

Copy link
Copy Markdown
Contributor

Note: This architectural proof-of-concept is currently undergoing manual revision to strip away remaining AI-scaffolding and securely restructure the underlying logic to meet strict Montage maintainer standards.

This commit patches the admin_endpoints validation to gracefully handle empty POST bodies, and modifies MessageMiddleware to intercept MontageErrors so they correctly return 400 Bad Request JSON instead of bypassing CORS headers. Resolves Issue hatnote#357.
Bind :disabled='isLoading' on vote buttons to block concurrent clicks at DOM level before Vue's async re-render cycle can prevent them.
…atnote#325)

getRoundVotesStats was defined in jurorService but never called. Added onMounted fetch and post-vote refresh in VoteRating.vue and VoteYesNo.vue, with conditional rendering when round.show_stats is true.
editVoteContainer ref is inside a v-else-if block and is null at onMounted, so the scroll listener was never attached. Replaced with watch(editVoteContainer) to attach the listener once the element renders.
When a file has been reuploaded (oi_archive_name is set), use rec_img_timestamp and rec_img_text for upload_date and upload_user_text respectively — these reflect the original first upload, which is what competition eligibility checks (dq_by_upload_date, dq_by_uploader) should be based on.
@ayushshukla1807
ayushshukla1807 force-pushed the fix-upload-date-from-first-version branch from 873b62a to 9f8ff8a Compare March 23, 2026 04:40
@ayushshukla1807

Copy link
Copy Markdown
Contributor Author

I am closing this PR to reduce repository noise. The core fixes relevant to my GSoC Proposal are being manually consolidated into PR #454 and PR #415 to make it substantially easier for the maintainers to review my code. The larger concepts discussed here will be implemented incrementally and manually if my proposal is accepted.

@ayushshukla1807

Copy link
Copy Markdown
Contributor Author

Closing this conceptual proposal. Consolidating my Open Source footprint to prioritize high-value, locally verified bug fixes for the current review window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant