Fixes #322 Edit votes loads only 15 images (scroll listener race condition) - #418
Closed
ayushshukla1807 wants to merge 4 commits into
Closed
Fixes #322 Edit votes loads only 15 images (scroll listener race condition)#418ayushshukla1807 wants to merge 4 commits into
ayushshukla1807 wants to merge 4 commits into
Conversation
ayushshukla1807
force-pushed
the
fix-edit-votes-infinite-scroll
branch
from
March 27, 2026 00:37
b1b675d to
2bcec5a
Compare
Contributor
Author
|
I am closing this PR to reduce repository noise. The core fixes relevant to my GSoC Proposal are being manually consolidated into PR #454 and PR #415 to make it substantially easier for the maintainers to review my code. The larger concepts discussed here will be implemented incrementally and manually if my proposal is accepted. |
ayushshukla1807
force-pushed
the
fix-edit-votes-infinite-scroll
branch
from
April 3, 2026 19:06
2bcec5a to
a846b6c
Compare
Contributor
Author
🧪 Local Testing VerificationVerified locally. The scroll-listener race condition has been patched. The Vue component is correctly detecting the scroll depth and firing the subsequent pagination network requests. As shown below, scrolling down the gallery correctly loads the 16th+ images without hanging.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #322.
Edit Votes was dropping the queue after 15 images because the intersection observer was firing out of order. Adjusted the listener hook.