Skip to content

fix: Round data invalid reloader on round deletion - #380

Merged
Jayprakash-SE merged 1 commit into
hatnote:masterfrom
ItsAbhinavM:379-SPA-reload-round-delete
May 3, 2026
Merged

fix: Round data invalid reloader on round deletion#380
Jayprakash-SE merged 1 commit into
hatnote:masterfrom
ItsAbhinavM:379-SPA-reload-round-delete

Conversation

@ItsAbhinavM

@ItsAbhinavM ItsAbhinavM commented Feb 25, 2026

Copy link
Copy Markdown
Collaborator

Description

Fixes #379
Vue js uses SPA routing for navigation, and currently we were using router.reload() which does not exists. This PR fixes it with a relevant data reload instead of web page reload.

@ayushshukla1807 ayushshukla1807 mentioned this pull request Mar 21, 2026
Closed
@lgelauff

lgelauff commented Apr 12, 2026

Copy link
Copy Markdown
Collaborator

Basically a duplicate with #435

@Jayprakash-SE
Jayprakash-SE merged commit b613b20 into hatnote:master May 3, 2026
@lgelauff lgelauff mentioned this pull request Jun 18, 2026
Merged
Jayprakash-SE pushed a commit that referenced this pull request Jun 26, 2026
@lgelauff @claude
fix(frontend): remove unused router import in RoundEdit.vue (#588)
8e788a7 
`useRouter`/`router` became dead code after #380 (b613b20) replaced the
router.reload call with a data reload, but the import was left behind.
Fails `no-unused-vars`, which breaks lint on every branch.

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
@ItsAbhinavM ItsAbhinavM mentioned this pull request Jul 6, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Invalid router.reload() in round deletion

3 participants

@ItsAbhinavM @lgelauff @Jayprakash-SE