Strip prefixes added by DuplicateRecordFields #4593
Merged
fendor merged 4 commits intohaskell:masterfrom May 24, 2025
Merged
Conversation
fendor
approved these changes
May 19, 2025
Collaborator
fendor
left a comment
There was a problem hiding this comment.
LGTM, thanks for taking care of this issue!
Just one comment.
Contributor
Author
|
Thanks for the review. Applied your comments. |
fendor
approved these changes
May 19, 2025
Collaborator
8d209ea to
0519351
Compare
0519351 to
deb8901
Compare
Contributor
Author
|
Done. No problem, thanks for helping :)
Is there anything I need to do ? |
Collaborator
|
Thank you for your PR and your work, it is much appreciated!
Choosing another issue to fix? ;D |
duke13137
pushed a commit
to duke13137/haskell-language-server
that referenced
this pull request
May 25, 2025
* Strip prefixes added by DuplicateRecordFields to disambiguate record selectors from inlay hints * Fix style * Extract stripPrefixes to a common utility, convert comment to haddoc * Move to GHC Util
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for: #4547
DuplicateRecordFields adds
$sel:...:fieldNameto disambiguate record selectors. The selectors are included in the inlay hints making them slightly confusing: