Use operational master commit to fix build for ghc-9.0.1 - #2017
Merged
Conversation
jneira
commented
Jul 13, 2021
Member
- To fix ci for ghc-9.0.1
- Fixes CI for 9.0.1 is broken due to missing upstream commit #2016
Ailrun
reviewed
Jul 13, 2021
Ailrun
left a comment
Member
There was a problem hiding this comment.
Thank you. BTW, cabal-ghc901.project should also be fixed to make CI work.
Member
Author
thanks! i was just about to commit the change |
Collaborator
|
This fixes it, but CI is flaky af. I've restarted CI and maybe one day we'll be able to get code merged again :) |
berberman
approved these changes
Jul 14, 2021
berberman
left a comment
Collaborator
There was a problem hiding this comment.
Many thanks, I also updated the nix config for ghc 9.0.1 here
Member
Author
yeah, I am gonna disable tests for Windows and 9.0.1 😟 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.