Fix #8719. Local tarballs are not local packages.#8723
Closed
phadej wants to merge 1 commit intohaskell:masterfrom
Closed
Fix #8719. Local tarballs are not local packages.#8723phadej wants to merge 1 commit intohaskell:masterfrom
phadej wants to merge 1 commit intohaskell:masterfrom
Conversation
Collaborator
Author
|
Actually I think this change breaks the whole fix done #8623, the idea how to fix the issue there is wrong. local tarballs are not local packages, if you ask me, that's not negotiable. So i expect tests to fail. I'll let maintainers decide how to proceed. #8719 is important issue, it causes project planning failure. |
Member
Oleg, could you elaborate? Does it break --lib as it was before the PR (#8744) or would it only break any suspected improvement to --lib that this PR supposedly confers? |
Collaborator
Author
I don't know. |
Member
|
OK, Thank you. In that case I won't worry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This breaks
cabal install --libI guess. But it's broken anyway, so I don't mind.