Bump cabal-bootstrap-gen to GHC 9.4.4 ecosystem#8720
Bump cabal-bootstrap-gen to GHC 9.4.4 ecosystem#8720mergify[bot] merged 1 commit intohaskell:masterfrom
Conversation
|
This should probably add GHC 9.4.4 to |
|
@nmeum: BTW, please feel free to compare with old PRs that update the generator and/or generate files for new GHCs. |
b8e939e to
1ad2af3
Compare
I tried to follow #8403 but somehow this PR didn't include changes to the top-level |
robx
left a comment
There was a problem hiding this comment.
This looks good to me, though I haven't tested it locally. Bootstrap CI passes so the generated files should be fine at least. (CI doesn't cover bootstrap-gen itself.)
|
Let me rebase so that CI unbreaks (we worked around some infrastructure breakage). @nmeum: did you perchance test the new scripts with GHCs other than 9.4.4? Ideally with all listed in the Makefile? I guess it's fine if they produce differenct bootstrap files than in the repo, but a smoke test would be comparing if the sizes are similar. After your are satisfied about your due diligence, please kindly set the merge_me label. |
|
@mergify rebase |
|
To get the future behavior now, you can configure Or you can create a dedicated github account for squash and rebase operations, and use it in different |
✅ Branch has been successfully rebased |
1ad2af3 to
406637f
Compare
|
@mergify rebase |
|
To get the future behavior now, you can configure Or you can create a dedicated github account for squash and rebase operations, and use it in different |
406637f to
fad601e
Compare
✅ Branch has been successfully rebased |
|
Given that this passes CI and has been approved: Do you need me to do anything else to get this merged or is it just a question of time? :) |
|
@nmeum All good on our side, you may set the label |
|
@nmeum: as as @Kleidukos said. And feel free to read CONTRIBUTING.md if in doubt. BTW, did you catch the below comment of mine?
|
Sorry, I somehow missed your comment. I only tested this with GHC 9.4.4. I am using this changeset for bootstrapping Cabal for the Alpine Linux Cabal package and hence have only tested this with the GHC version available in the Alpine repositories (9.4.4). |
That's fine. If somebody manages to test during the 2 days delay period after setting the label, it'd be great. But if not, we still have a long time before cabal 3.10.2 or 3.12, so we may hear from other boostrappers and fix, as necessary. |
I updated the dependencies in the .cabal bootstrap file and sightly adjusted src/Main.hs for the `I.riCabal → I.riCabalHash` change. Fixes haskell#8613
|
To get the future behavior now, you can configure Or you can create a dedicated github account for squash and rebase operations, and use it in different |
fad601e to
2de1fdc
Compare
|
I wonder if we should backport this to 3.10? I guess so. Let me create a backport PR and then ask people. |
|
@mergify backport 3.10 |
✅ Backports have been createdDetails
|
Bump cabal-bootstrap-gen to GHC 9.4.4 ecosystem (backport #8720)
I updated the dependencies in the .cabal bootstrap file and sightly adjusted src/Main.hs for the
I.riCabal → I.riCabalHashchange. I successfully bootstrapped Cabal on Alpine Linux Edge with these changes. I am new to Cabal so let me know if this needs any adjustments.Fixes #8613
Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!