Backport the dotsection fix to the 0.25 series for a patch release - #229
Closed
tobocop2 wants to merge 1 commit into
Closed
Backport the dotsection fix to the 0.25 series for a patch release#229tobocop2 wants to merge 1 commit into
tobocop2 wants to merge 1 commit into
Conversation
dotsection (escape 12 0) is a Type 1 hinting operator that Adobe's
Type 1 to Type 2 conversion preserves on dot-bearing glyphs, so
distiller-produced Type 1C subsets carry it routinely. The two-byte
operator match only knew the flex family and returned
CFFError::UnsupportedOperator, which aborted the entire charstring:
glyphs such as i, j, period, colon, exclam and question yielded no
outline at all instead of an outline missing hinting metadata.
The operator takes no arguments and only brackets outline sections
for hinters, so treat it as a pure no-op, matching read-fonts
('Nothing to do.') and FreeType. A second test pins the no-op
semantics: operands already on the stack survive it untouched.
(cherry picked from commit 023f816)
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this is
The #228 fix (ignore the deprecated
dotsectionoperator instead of failing the whole charstring, #227) cherry-picked onto thev0.25.1tag, so a 0.25.2 patch release can be tagged directly from this branch.Why a backport
Consumers hit the bug through released crates: pdf_oxide, fontdb and anything else outlining Type 1C subsets pin
0.25. A patch release delivers the fix downstream immediately; the main-branch fix in #228 only ships with the next minor.Validation
Identical change and tests to #228. Full suite passes on this branch (151 tests); control glyphs keep byte-identical outlines.
If you would rather cherry-pick onto your own release branch and tag from there, feel free to close this.