Conversation
Closes hanami#481
Codecov Report
@@ Coverage Diff @@
## unstable #482 +/- ##
============================================
+ Coverage 98.73% 98.73% +<.01%
============================================
Files 108 108
Lines 5513 5527 +14
============================================
+ Hits 5443 5457 +14
Misses 70 70
Continue to review full report at Codecov.
|
jodosha
left a comment
There was a problem hiding this comment.
@artofhuman Thanks for this PR, but there is a change to be done before to merge. My apologize for the wrong description in #481
Given Hanami::Model::Configuration isn't directly instantiated, but it's done indirectly via:
Hanami::Model.configure do
# ...
endWe need to find a way for .configure to accept a custom inflector and/or custom inflections.
|
@jodosha thanks for review, i`ll try to implement |
|
@artofhuman Please let me know in case you'll need help. Thanks. 😃 |
|
@jodosha could you check? |
jodosha
left a comment
There was a problem hiding this comment.
@artofhuman Thanks it looks better now. I'd call for a second review, if you don't mind. 😃
|
@jodosha ok ;) |
|
Already merged but looks fine to me too ;) |
Closes #481