Some minor changes at TicketManager#127
Merged
phansys merged 1 commit intohackzilla-project:masterfrom Dec 6, 2018
Merged
Conversation
7396227 to
cabe387
Compare
phansys
added a commit
that referenced
this pull request
Dec 6, 2018
This PR was merged into the master branch.
Discussion
----------
|Q |A |
|--- |--- |
|Branch |master|
|Bug fix? |no |
|New feature? |no |
|BC breaks? |yes |
|Deprecations?|no |
|Tests pass? |yes |
|Fixed tickets|n/a |
|License |MIT |
|Doc PR |n/a |
* Renamed method `TicketManagerInterface::getTicketList()` to `TicketManagerInterface::getTicketListQuery()`
to clarify what it returns;
* `TicketManagerInterface::updateTicket()` now returns `void`, since the object (`TicketInterface`) it was returning before is the same as the provided in its argument 1.
Commits
-------
cabe387 Some minor changes at `TicketManager`
phansys
added a commit
to phansys/TicketBundle
that referenced
this pull request
Jun 30, 2020
phansys
added a commit
to phansys/TicketBundle
that referenced
this pull request
Jun 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TicketManagerInterface::getTicketList()toTicketManagerInterface::getTicketListQuery()to clarify what it returns;
TicketManagerInterface::updateTicket()now returnsvoid, since the object (TicketInterface) it was returning before is the same as the provided in its argument 1.