Fix colors when in electron renderer process#16
Merged
haadcode merged 2 commits intoAug 1, 2018
Merged
Conversation
e58b1f5 to
20e4355
Compare
Since an electron renderer process is still a node process but the logs appear in a chromium browser, we should use css colors when an electron renderer environment is detected. Resolves issue: haadcode#15
20e4355 to
b934907
Compare
Owner
|
Makes sense. Nice and small fix 🙂Thank you! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since an electron renderer process is still a node process but the
logs appear in a chromium browser, we should use css colors when an
electron renderer environment is detected.
Resolves issue: #15