Fix conditionally requiring functions.php #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Mostly-identical PRs for guzzle/guzzle and guzzle/psr7 were filed: |
mtdowling
added a commit
that referenced
this pull request
Jun 30, 2015
Fix conditionally requiring functions.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The solution currently being used for conditionally autoloading functions does not work: PHP will attempt to load the functions before the conditional is evaluated. React had a similar problem (see reactphp/promise#25) which which was solved using a shim
functions_include.phpfile that checks for the existence of the first function withinfunctions.phpbefore includingfunctions.php. This PR modifies the conditional require to use React's method.