Switch Console.WriteLine over to Debug.WriteLine so as not to use Console.Out as debug log#111
Merged
Merged
Conversation
… Console.Out as debug log
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesStreaming logging
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original code is using
Console.Outfor debug messages. I didn't want to outright strip them away, but they are noise in terms of using this library, especially if you're trying to write a CLI tool, like I am.If the library requires a
TextWriterto write debug messages to, either a different one should be used, or an optional override property should be provided so that users of the package can opt-out of this debug log.Instead, I switched the offending lines to use
Debug.WriteLine. If the lines have served their purpose, however, they should probably be removed instead.I did not get to run all unit tests successfully, as it relied on locally installed npx, which I don't have, and I suspect the official list of models from Google has changed so that some of the tests that ensure models exists are also failing. I did not, however, find any tests related to using the offending debug log messages, so I assumed it was safe to make the switch.
Summary by CodeRabbit