Add navigation arrows to product carousel.#15025
Merged
oliverabrahams merged 22 commits intomainfrom Jan 20, 2026
Merged
Conversation
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
… subgrid, and link to the product text heading using the H2. The product element heading h2Id is added using the enhancers in dcr
…f the card using Visable slides on either mobile or tablet. Remove the css in the carousel that is front specific and put that behind the !isArticle boolean
…l carousel. There will be a future PR for carousels with 2 cards + stories
f20853d to
a064393
Compare
ae03857 to
1f51155
Compare
Contributor
|
Looks good! Have we tested this for accessibility e.g. keyboard navigation etc? |
…t much more intuitive. And allows us to remove the prop isArticle
…lableProduct.importable.tsx
1f51155 to
e00530d
Compare
Contributor
Author
I have tried keyboard navigation and it all seems to work 👍 |
charleycampbell
approved these changes
Jan 19, 2026
# Conflicts: # dotcom-rendering/src/components/ScrollableProduct.importable.tsx # dotcom-rendering/src/components/ScrollableProducts.stories.tsx
|
Seen on PROD (merged by @oliverabrahams 7 minutes and 57 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds a Heading and navigation arrows to the product carousel.
Adds an interaction story to to the carousel storybook.
builds off this PR #14968
Screenshots