Skip to content

Set the security level of Windows named pipes to NoSecurity #6956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arvindbr8 merged 1 commit into from
Feb 14, 2024
Merged

Set the security level of Windows named pipes to NoSecurity #6956

arvindbr8 merged 1 commit into from
Feb 14, 2024

Conversation

@irsl
Copy link
Contributor

@irsl irsl commented Feb 1, 2024 •
edited
Loading

Communication over named pipes on Windows is local IPC.

RELEASE NOTES:

  • Set the security level of Windows named pipes to NoSecurity

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 1, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Feb 1, 2024 •
edited
Loading

Codecov Report

Merging #6956 (0537df0) into master (a3f5ed6) will decrease coverage by 1.28%.
Report is 9 commits behind head on master.
The diff coverage is 0.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6956      +/-   ##
==========================================
- Coverage   83.61%   82.33%   -1.28%     
==========================================
  Files         287      296       +9     
  Lines       30929    31434     +505     
==========================================
+ Hits        25860    25881      +21     
- Misses       3998     4488     +490     
+ Partials     1071     1065       -6
Files Coverage Δ
credentials/local/local.go 75.67% <0.00%> (-4.33%) ⬇️

... and 34 files with indirect coverage changes

dfawley
dfawley reviewed Feb 1, 2024
View reviewed changes
@irsl irsl changed the title Set the security level of Windows named pipes to NoSecurity Set the security level of Windows named pipes to PrivacyAndIntegrity Feb 6, 2024
@irsl irsl changed the title Set the security level of Windows named pipes to PrivacyAndIntegrity Set the security level of Windows named pipes to NoSecurity Feb 8, 2024
@irsl
Set the security level of Windows named pipes to NoSecurity
0537df0 
Communication over named pipes on Windows is local IPC.
@ginayeh ginayeh assigned dfawley and unassigned irsl Feb 8, 2024
@ginayeh ginayeh added this to the 1.62 Release milestone Feb 8, 2024
@ginayeh ginayeh added the Type: Feature New features or improvements in behavior label Feb 8, 2024
@ginayeh ginayeh modified the milestones: 1.62 Release, 1.63 Release Feb 8, 2024
dfawley
dfawley approved these changes Feb 14, 2024
View reviewed changes
@dfawley dfawley removed their assignment Feb 14, 2024
@dfawley dfawley requested a review from arvindbr8 February 14, 2024 18:41
arvindbr8
arvindbr8 approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@arvindbr8 arvindbr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR

@arvindbr8 arvindbr8 merged commit f94be9b into grpc:master Feb 14, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@matthewstevenson88 matthewstevenson88 matthewstevenson88 left review comments

@dfawley dfawley dfawley approved these changes

+1 more reviewer

@arvindbr8 arvindbr8 arvindbr8 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@arvindbr8 arvindbr8

Labels

Type: Feature New features or improvements in behavior

Projects

None yet

Milestone

1.63 Release

Development

Successfully merging this pull request may close these issues.

5 participants

@irsl @arvindbr8 @dfawley @matthewstevenson88 @ginayeh