Skip to content

update_dependencies.py : Add flask,pytz,python-dotenv modules.#255

Merged
a-gavin merged 1 commit into
greearb:masterfrom
goyalsaurabh06:update_dependencies_extra
May 7, 2026
Merged

update_dependencies.py : Add flask,pytz,python-dotenv modules.#255
a-gavin merged 1 commit into
greearb:masterfrom
goyalsaurabh06:update_dependencies_extra

Conversation

@Sidartha-CT
Copy link
Copy Markdown
Contributor

@Sidartha-CT Sidartha-CT commented May 7, 2026

Hi @smileyrekiere ,
These modules are required for the upcoming PR (lf_multi_traffic.py — new file). In this file, classes are externally imported from the py-scripts/real_application_tests/ directory, and those scripts depend on modules such as flask, pytz, and python-dotenv.

When I pushed the commits for lf_multi_traffic.py in our forked scripts repo for the purpose of PR, the CI HELPER linter (part of the GitHub Actions workflow) failed. Therefore, these modules need to be added to update_dependencies.py to ensure the GitHub Action (HELPER CHECK) passes successfully.

Previously, these dependencies were not flagged when pushing real_application_tests because the CI linter (lf_help_check.py) only runs for scripts strictly present under py-scripts/. As a result, scripts inside py-scripts/real_application_tests were not being checked.

It would also be good to include the dependencies required by the real application tests in the same update_dependencies.py file for consistency and to avoid similar issues in the future.

Please let me know if there are any concerns.

++ @a-gavin @goyalsaurabh06

Signed-off-by: Sidartha-CT <neelapu.sidartha@candelatech.com>
@a-gavin
Copy link
Copy Markdown
Collaborator

a-gavin commented May 7, 2026

@Sidartha-CT Looks good to me, I'll merge.

Can you please add a follow-up PR which implements linting for the real application tests? I'd be curious to hear if any other directories are not presently linted but do not have time to do so as of now

@a-gavin a-gavin self-requested a review May 7, 2026 17:24
@a-gavin a-gavin merged commit 374547c into greearb:master May 7, 2026
2 checks passed
@Sidartha-CT
Copy link
Copy Markdown
Contributor Author

Sidartha-CT commented May 8, 2026

@a-gavin, quick question on the linting scope, should it cover all scripts that reside under py-scripts/ recursively? That would include:

  • Scripts directly under py-scripts/*.py
  • Scripts inside any deeply nested subdirectories, such as py-scripts/anydir/anydir/*.py

I made the following change in lf_help_check.py:

diff --git a/py-scripts/tools/lf_help_check.py b/py-scripts/tools/lf_help_check.py
index 61af1369..12cacf5b 100755
--- a/py-scripts/tools/lf_help_check.py
+++ b/py-scripts/tools/lf_help_check.py
@@ -12,7 +12,7 @@ import logging
 import os
 import subprocess
 from time import sleep, time
-
+import pathlib
 THIS_SCRIPT_NAME = os.path.basename(__file__)
 
 
@@ -303,7 +303,10 @@ if __name__ == "__main__":
         exit(2)
 
     # Gather all Python scripts in all sub-directories
-    all_scripts = glob.glob("./*.py") + glob.glob("./**/*.py")
+    all_scripts = [
+    str(p) for p in pathlib.Path(".").rglob("*.py")
+    if "venv" not in p.parts and "site-packages" not in p.parts
+]
 
     # Gather and report help check scripts
     help_check_scripts = [file for file in all_scripts if desired_script(file)]

With this update, the linting/help check now also covers scripts under real_application_tests/, and it will automatically include any new directories created under py-scripts/ in the future.

Current output:

ERROR: The following scripts failed help check: ['real_application_tests/teams_automation/teams_android_app.py', 'real_application_tests/teams_automation/teams_android.py', 'real_application_tests/zoom_automation/android_zoom.py', 'real_application_tests/youtube/youtube_android_test.py']

ERROR: The following scripts failed help summary check: ['real_application_tests/teams_automation/teams_android_app.py', 'real_application_tests/teams_automation/teams_android.py', 'real_application_tests/teams_automation/lf_interop_teams.py', 'real_application_tests/real_browser/lf_interop_real_browser_test.py', 'real_application_tests/zoom_automation/android_zoom.py', 'real_application_tests/zoom_automation/lf_interop_zoom.py', 'real_application_tests/youtube/youtube_android_test.py', 'real_application_tests/youtube/lf_interop_youtube.py']

Haha, there are quite a few scripts getting flagged now 😅. We'll need to fix them accordingly 🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants