Skip to content

lf_interop_real_browser_test.py : generate nav_data.json when triggered from WebUI#253

Merged
a-gavin merged 1 commit into
greearb:masterfrom
goyalsaurabh06:real_browser_pr
May 7, 2026
Merged

lf_interop_real_browser_test.py : generate nav_data.json when triggered from WebUI#253
a-gavin merged 1 commit into
greearb:masterfrom
goyalsaurabh06:real_browser_pr

Conversation

@kadalinikhita
Copy link
Copy Markdown
Contributor

No description provided.

…ed from WebUI

VERIFIED CLI : python3 lf_interop_real_browser_test.py --mgr 192.168.207.78 --url https://google.com --duration 1m --debug --upstream_port 192.168.204.93 --coordinates 1,4 --do_robo --robo_ip 192.168.206.63 --device_list 1.15,1.10

Signed-off-by: kadalinikhita <kadali.nikhita@candelatech.com>
@a-gavin
Copy link
Copy Markdown
Collaborator

a-gavin commented May 7, 2026

Code changes look fine. Will approve, but please ensure that the commit message is properly formatted (separate initial message from more verbose explanation and verified CLI). We have docs for this internally with specific examples.

With commit messages like that in this PR, it can clutter the log making it difficult to read. I have seen this with quite a few commits over the last several months.

lf_interop_real_browser_test.py : generate nav_data.json when triggered from WebUI
VERIFIED CLI : python3 lf_interop_real_browser_test.py --mgr 192.168.207.78 --url https://google.com/ --duration 1m --debug --upstream_port 192.168.204.93 --coordinates 1,4 --do_robo --robo_ip 192.168.206.63 --device_list 1.15,1.10

For example:

$ git log --oneline
b3beb4b0 (HEAD -> master, origin/master, origin/HEAD) lf_interop_youtube.py : add resolution parameter for youtube android script VERIFIED CLI :  python3 lf_interop_youtube.py --mgr 192.168.207.78 \                                               --url https://youtu.be/BHACKCNDMW8?si=psTEUzrc77p38aU1 \                                               --duration 1 \                                               --test_name Youtube \                                               --res 720p \                                               --upstream_port eth1 Signed-off-by: sivakondri-CT <kondru.sankar@candelatech.com>
67209ffd py-scripts/tools/lf_inspect.py     updated to not report a failure when Auth Timeouts or Association Rejects     is zero.     Verification:     Automation
992f4cb1 py-scripts/tools/lf_inspect.py     updated to not report a failure when Auth Timeouts or Association Rejects     is zero.     Verification:     Automation
c8beb0d2 test_l3.py : Remove print and modified condition to filter bssid for bandsteering VERIFIED_CLI : python3 test_l3.py  --lfmgr 192.168.207.78 --test_duration 1m --polling_interval 1s --upstream_port eth1 --endp_type mc_udp --rates_are_totals --side_b_min_bps=10000000 --test_tag test_l3 --cleanup_cx --tos BE --real --robot_test --robot_ip 127.0.0.1:5000 --do_bandsteering --cycles 1 --coordinate 3,4
7c1ccf8f test_l3.py : Add condition in report for bandsteering VERIFIED_CLI : python3 test_l3.py  --lfmgr 192.168.207.78 --test_duration 1m --polling_interval 1s --upstream_port eth1 --endp_type mc_udp --rates_are_totals --side_b_min_bps=10000000 --test_tag test_l3 --cleanup_cx --tos BE --real --robot_test --coordinate 2,21 --robot_ip 192.168.204.74 --do_bandsteering --cycles 3 --bssids 94:A6:7E:74:26:33,94:A6:7E:74:26:22
fc712567 Add bandsteering parameters into object and set duration to skip to default value of 60sec VERIFIED CLI : python3 test_l3.py  --lfmgr 192.168.207.78 --test_duration 1m --polling_interval 1s --upstream_port eth1 --endp_type mc_udp --rates_are_totals --side_b_min_bps=10000000 --test_tag test_l3 --cleanup_cx --tos BE --real --robot_test --coordinate 2,21 --robot_ip 192.168.204.74 --do_bandsteering --cycles 3 --bssids 94:A6:7E:74:26:33,94:A6:7E:74:26:22
9ac93ec0 lf_interop_zoom.py: Fix linting issues
ba951929 lf_interop_zoom.py: Add Example CLI's Verified CLI: python3 lf_interop_zoom.py --lanforge_ip 10.17.1.208 --signin_email demo@gmail.com --signin_passwd demo123 --participants 2 --audio --video --upstream_port 10.17.1.68 --robo_ip 127.0.0.1:6000 --coordinates 1,2 --cycles 2 --do_bs --api_stats_collection --env_file .env --bssids 00:11:22:33:44:55,66:77:88:99:AA:BB
...

CC: @goyalsaurabh06 @Sidartha-CT @kadalinikhita (please let others know as well)

@a-gavin a-gavin self-requested a review May 7, 2026 17:29
@a-gavin a-gavin merged commit 10fc2cb into greearb:master May 7, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants