feat: add Herdr terminal jump support - #164
Open
lchojnowski wants to merge 1 commit into
Open
Conversation
Author
|
@graykode, this is ready for review. It adds the requested Herdr terminal-jump backend, includes exact-PID and fail-closed coverage, and has been verified end to end against Herdr 0.7.5 across workspaces. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Safety and compatibility
HERDR_SOCKET_PATHand require an exact PID matchHerdr references: CLI reference and agent guide.
Testing
rustfmt +1.88.0 --edition 2021 --check src/jump/herdr.rs src/jump/mod.rs src/app.rscargo clippy --all-targets -- -D warningscargo test --all-targets(210 passed)cargo build --releasecargo check --target x86_64-unknown-linux-gnucargo check --target x86_64-pc-windows-gnugit diff --check--exit-on-jumpreturned the source pane to its shell after success