feat: Accept ReadonlyArray<T> for enum members#916
Merged
jasonkuhrt merged 2 commits intographql-nexus:mainfrom May 25, 2021
Merged
feat: Accept ReadonlyArray<T> for enum members#916jasonkuhrt merged 2 commits intographql-nexus:mainfrom
ReadonlyArray<T> for enum members#916jasonkuhrt merged 2 commits intographql-nexus:mainfrom
Conversation
23c77ab to
30d7d15
Compare
Codecov Report
@@ Coverage Diff @@
## main #916 +/- ##
=======================================
Coverage 93.91% 93.91%
=======================================
Files 46 46
Lines 2957 2960 +3
Branches 692 692
=======================================
+ Hits 2777 2780 +3
Misses 178 178
Partials 2 2 |
ReadonlyArray<T> for enum members
jasonkuhrt
reviewed
May 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #455
I added in a new
isArrayutil which just callsArray.isArraybut correctly narrows the type of the input. This is to workaround the issue described here, the solution was taken from the since reverted microsoft/TypeScript#39258