Skip to content

Allow accessing send queue count from WebSocketConnection#1156

Merged
Shane32 merged 2 commits intomasterfrom
queuecount
Oct 20, 2024
Merged

Allow accessing send queue count from WebSocketConnection#1156
Shane32 merged 2 commits intomasterfrom
queuecount

Conversation

@Shane32
Copy link
Copy Markdown
Member

@Shane32 Shane32 commented Oct 7, 2024

Allows derived classes to check the send queue count and override SendMessageAsync in case the number of messages in the outbound queue is growing out of control. Perhaps in the future backpressure options will be available as a built-in feature, but with #1154 it should not be necessary.

@Shane32 Shane32 added this to the 8.1.0 milestone Oct 7, 2024
@Shane32 Shane32 requested a review from gao-artur October 7, 2024 04:52
@Shane32 Shane32 self-assigned this Oct 7, 2024
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.79%. Comparing base (a84c553) to head (9d25258).
⚠️ Report is 43 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1156      +/-   ##
==========================================
- Coverage   90.88%   90.79%   -0.10%     
==========================================
  Files          50       50              
  Lines        2425     2433       +8     
  Branches      432      433       +1     
==========================================
+ Hits         2204     2209       +5     
- Misses        175      176       +1     
- Partials       46       48       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants