Pin graphql-voyager to 1.3.0, fix #1152#1153
Pin graphql-voyager to 1.3.0, fix #1152#1153Shane32 merged 3 commits intographql-dotnet:masterfrom nightroman:master
Conversation
|
Let's pin 2.0.0; it has been in use for a year now, right? |
But it does not work for me with 2.0.0. |
|
Take a looks at 1.3.0 (works fine) and 2.0.0 (Loading... infinitely) |
No, it hasn't been: in 2.0, However, the corresponding CSS file is still present in 2.0, so there was CSS from 2.0 and JS from 1.3 for a year. Switching to the new |
|
Ok sounds good. Let's add the sha hash to the tag to ensure it does not change in the future, and I'll merge it. |
Sorry, I am not sure what this is. Is it something I should do? |
|
Probably some website like this can calculate it. |
|
I assume the hosting code needs to be updated for the 2.0 version to work? |
|
@alexander-jesner-AP Yes, I think so and hope this will be eventually the case, the proper fix. That's why I mentioned the same example in #1152 @Shane32 I have engaged for the quick fix of the regression, to make things working again. I now see it's getting more involved and it's not really my area of expertise. At the moment I am not able to implement what you are requesting. Thank you for your help. |
|
I'll issue a release with it pinned to 1.3.0 If someone wants to post a PR with it properly upgraded to 2.x, we can merge that in subsequently. |
No description provided.