Error for array of address field.

[realchoubey]

With Array of address field graph-cli generate field as [Bytes] which fails while codegen.

On fixing [Bytes] to [Bytes!] in conversion file we are getting error below error as array of bytes cannot be directly assigned to array of address.

ERROR TS2322: Type '~lib/array/Array<~lib/@graphprotocol/graph-ts/common/numbers/Address>' is not assignable to type '~lib/array/Array<~lib/@graphprotocol/graph-ts/common/collections/Bytes>'.

Suggestion:
As we don't have support directly from thegraph for address type attributes (We get validation error), we need to generate code which will loop-over the array fields.

[azf20]

Hi! Can you provide a bit more detail on when you see this error - is this coming from auto-generated graph codegen code? Do you have a test case or example where you are seeing this error?

[pablote]

I've just run into this issue, it's fairly easy to reproduce. Just have a contract with an event, with one of it's args being a address[]. This causes graph init to generate the following Graphql code:

...
owners: [Bytes]! # address[]
...

Graphql doesn't seem to like this:

GraphQL schema can't have List's with Nullable members.
Error in 'owners' field of type '[Bytes]'.
Suggestion: add an '!' to the member type of the List, change from '[Bytes]' to '[Bytes!]'

The solution, as suggested by the error message, is to change that line to:

owners: [Bytes!]! # address[]

The problem with this is that, since this fails during the graph init command, now I don't know if that did all it needed to do, or if there were some steps skipped because of the error. The fix should just be to generate the correct Graphql types.

[pablote]

Well, the change mentioned above only fixes codegen. When you try to build the subgraph it fails. The line that fails is the one trying to map the address[] from the event to the entity: entity.owners = event.params.owners.

The error is the same from this other issue: #1017

I've tried to rewrite that line in different ways, but nothing seems to fully work. These two options also crash the assemblyscript compiler for some reason:

entity.owners = event.params.owners.map((x) => x);

entity.owners = [];
  event.params.owners.forEach((x) => {
    const bytes = x as Bytes;
    const copy = Bytes.fromHexString(bytes.toHexString());
    entity.owners.push(copy);
  });

And then this variant builds and deploys, but then, querying the GraphQL API doesn't return data for the owners property, again, not sure why:

  // entity.owners = new Array(event.params.owners.length);
  entity.owners = [];
  for (let i = 0; i < event.params.owners.length; i++) {
    // entity.owners[i] = event.params.owners[i];
    // if (event.params.owners[i]) {
    entity.owners.push(event.params.owners[i]);
    // }
  }

I suppose address[] is just not working now, and that's a blocker for me at the moment :(

[sdakhara]

I have also tried to do exactly what CLI told
after changing the owners: [Bytes]! # address[] to owners: [Bytes!]! # address[] the graph codegen command worked compeletly fine but
when I run the build command it shows me the error that I mentioned in my issue #1017

and i have did some digging and changed the type in ts file which is used for build

entity.targets = changetype<Bytes[]>(event.params.targets)

here the event.params.targets is an Address[] and entity.targets is a Bytes[]
so i have changed it's type with changetype<Bytes[]>.

i don't know if this is a good fix or not but it worked.

[YaroShkvorets]

Contract 0xe1844c5D63a9543023008D332Bd3d2e6f1FE1043
Network: Japan Open Chain

ERROR TS2322: Type 'Array<Address>' is not assignable to type 'Array<Bytes>'.

   entity.requiredDVNs = event.params.requiredDVNs
                         ~~~~~~~~~~~~~~~~~~~~~~~~~
 in src/send-uln-302.ts(32,25)

Wrapping in changetype<Bytes[]>() works