Small scalability improvements for offchain data sources #6043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fordN
reviewed
May 30, 2025
graph/src/env/mappings.rs
Outdated
| disable_declared_calls: EnvVarBoolean, | ||
| #[envconfig(from = "GRAPH_STORE_ERRORS_ARE_NON_DETERMINISTIC", default = "false")] | ||
| store_errors_are_nondeterministic: EnvVarBoolean, | ||
| #[envconfig(from = "Graph_FDS_MAX_BACKOFF", default = "600")] |
Contributor
There was a problem hiding this comment.
Use all caps for env var key? GRAPH_FDS_MAX_BACKOFF?
Collaborator
Author
There was a problem hiding this comment.
Whoa .. nice catch. That was CoPilot, crazy
fordN
approved these changes
May 30, 2025
Contributor
fordN
left a comment
There was a problem hiding this comment.
Looks good to merge once the formatting comment on the ENV var is addressed. 👍
0574ed0 to
cbfb912
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
GRAPH_FDS_MAX_BACKOFF(in seconds) The default is 600 as it was before this PR