Bump IPFS client max retry delay to 60 seconds #5995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We add a new configurable max delay between retries, which defaults to 60 seconds for requests made via the IPFS client.
lutter
approved these changes
May 7, 2025
Collaborator
lutter
left a comment
There was a problem hiding this comment.
This effectively bumps the max delay between retries from 1s to 60s. That makes sense, but I don't understand why the description says this is configurable - it's still hardcoded to 60s AFAICT
Contributor
Author
Ah this is bad wording; I meant that the |
encalypto
added a commit
that referenced
this pull request
May 7, 2025
We add a new configurable max delay between retries, which defaults to 60 seconds for requests made via the IPFS client.
encalypto
added a commit
that referenced
this pull request
May 9, 2025
We add a new configurable max delay between retries, which defaults to 60 seconds for requests made via the IPFS client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add a new configurable max delay between retries, which defaults to 60 seconds for requests made via the IPFS client.