Remove GraphQL subscriptions #5836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also removes all testing of subscription functionality
This will never match since we do not send such events any more. Also remove the `graphman listen entities` command
All events are now for assignments, so there's no need to filter anything
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes support for GraphQL subscriptions as they are not available on the network, and the code is therefore pretty dead. Besides the actual websocket server, this also removes most of the internal gymnastics that were necessary to feed subscriptions. There's a few more simplifications that would be possible by modernizing the subgraph registrar to make it use
async, but that's a bit hairier