Add Docstring in SnowStormDataset#868
Open
christianlocatelli wants to merge 12 commits intographnet-team:mainfrom
Open
Add Docstring in SnowStormDataset#868christianlocatelli wants to merge 12 commits intographnet-team:mainfrom
SnowStormDataset#868christianlocatelli wants to merge 12 commits intographnet-team:mainfrom
Conversation
…r _prepare_args. I removed a redundant line for event_counts{} (line 124)
sevmag
requested changes
Feb 23, 2026
Collaborator
sevmag
left a comment
There was a problem hiding this comment.
Hey, thanks for the contribution! I left some comments to clarify things further. Once you implement those, this will be a valuable contribution that hopefully leads to more people using this class! :))))))
Contributor
Author
|
Hey Severin, thanks for the feedback I'll improve it asap! |
sevmag
approved these changes
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added more Information to the Docstring in
SnowStormDatasetand to the one in the function_prepare_args. I also removed the redundant line event_counts = {}.