feat(create-plugin): make Playwright config extendable - #2807
Open
alectimison-maker wants to merge 1 commit into
Open
feat(create-plugin): make Playwright config extendable#2807alectimison-maker wants to merge 1 commit into
alectimison-maker wants to merge 1 commit into
Conversation
alectimison-maker
requested review from
hugohaggmark and
joshhunt
and removed request for
a team
July 30, 2026 04:17
Contributor
Signed commits report1 of 1 commit between
This repository requires all commits to be signed. See GitHub docs on commit signature verification. |
|
|
1 similar comment
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
create-plugininto the managed.config/playwright.config.ts.playwright.config.tsas a small, user-owned override usingdefineConfig(baseConfig, overrides).This keeps Grafana-owned defaults updateable without overwriting plugin-specific Playwright customizations. It applies to newly scaffolded plugins; it intentionally does not rewrite existing root configs because those files may contain user changes.
This is a clean reimplementation of the stale-closed #1495 and incorporates its maintainer review feedback, including the requested
projectsoverride documentation.Which issue(s) this PR fixes:
Fixes #1366
Tests:
npm exec nx run @grafana/create-plugin:test -- --run --no-cache(272 passed)npm exec nx run @grafana/create-plugin:lint -- --no-cacheNX_SKIP_NX_CACHE=true npm exec nx run @grafana/create-plugin:typecheckNX_SKIP_NX_CACHE=true npm exec nx run @grafana/create-plugin:buildnpm run docs:test:ci(12 passed)npm run docs:buildnpm run typecheck, and rannpm exec playwright test -- --list(4 tests listed across the defaultauthandchromiumprojects)Special notes for your reviewer:
The generated root config retains the commented dotenv hook so users can customize environment loading without editing
.config/.