enhance: add method for recreating all credentials #951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grant Linville <[email protected]>
This was referenced Mar 11, 2025
Signed-off-by: Grant Linville <[email protected]>
drpebcak
previously approved these changes
Mar 12, 2025
thedadams
requested changes
Mar 13, 2025
pkg/credentials/store.go
Outdated
Comment on lines
241
to
265
| s.recreateAllLock.Lock() | ||
| authConfig, err := store.Get(serverAddress) | ||
| if err != nil { | ||
| s.recreateAllLock.Unlock() | ||
|
|
||
| if IsCredentialsNotFoundError(err) { | ||
| // This can happen if the credential was deleted between the GetAll and the Get by another thread. | ||
| continue | ||
| } | ||
| return err | ||
| } | ||
|
|
||
| if err := store.Erase(serverAddress); err != nil { | ||
| s.recreateAllLock.Unlock() | ||
| return err | ||
| } | ||
|
|
||
| if err := store.Store(authConfig); err != nil { | ||
| s.recreateAllLock.Unlock() | ||
| return err | ||
| } | ||
| s.recreateAllLock.Unlock() | ||
| } | ||
|
|
||
| return nil |
Contributor
There was a problem hiding this comment.
Writing a helper function for this will allow you to use defer s.recreateAllLock.Unlock().
njhale
previously approved these changes
Mar 13, 2025
Member
njhale
left a comment
There was a problem hiding this comment.
lgtm once Donnie's feedback is addressed.
Signed-off-by: Grant Linville <[email protected]>
thedadams
approved these changes
Mar 13, 2025
njhale
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for obot-platform/obot#1997