Skip to content

bug: fix default model provider #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ibuildthecloud merged 1 commit into from
Aug 15, 2024
Merged

bug: fix default model provider #800

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions pkg/remote/remote.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ type Client struct {
clientsLock sync.Mutex
cache *cache.Client
clients map[string]clientInfo
modelToProvider map[string]string
runner *runner.Runner
envs []string
credStore credentials.CredentialStore
Expand All @@ -39,17 +38,13 @@ func New(r *runner.Runner, envs []string, cache *cache.Client, credStore credent
envs: envs,
credStore: credStore,
defaultProvider: defaultProvider,
modelToProvider: make(map[string]string),
clients: make(map[string]clientInfo),
}
}

func (c *Client) Call(ctx context.Context, messageRequest types.CompletionRequest, status chan<- types.CompletionStatus) (*types.CompletionMessage, error) {
c.clientsLock.Lock()
provider, ok := c.modelToProvider[messageRequest.Model]
c.clientsLock.Unlock()

if !ok {
_, provider := c.parseModel(messageRequest.Model)
if provider == "" {
return nil, fmt.Errorf("failed to find remote model %s", messageRequest.Model)
}

Expand Down Expand Up @@ -108,10 +103,6 @@ func (c *Client) Supports(ctx context.Context, modelString string) (bool, error)
return false, err
}

c.clientsLock.Lock()
defer c.clientsLock.Unlock()

c.modelToProvider[modelString] = providerName
return true, nil
}

Expand Down