fix: do not add readOnly fields to the requestBody #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the spec readOnly fields SHOULD NOT be sent in the request, but maybe present in the response. The LLM has made several errors making calls when these fields are present by including the readOnly fields in the request and getting HTTP 422's. This change loops through the args, and drops readOnly fields from the requestBodyContent arg on the tool. Signed-off-by: Bill Maxwell <[email protected]>
ibuildthecloud
approved these changes
Jun 4, 2024
g-linville
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the spec readOnly fields SHOULD NOT be sent in the request, but maybe present in the response. The LLM has made several errors making calls when these fields are present by including the readOnly fields in the request and getting HTTP 422's.
This change loops through the args, and drops readOnly fields from the requestBodyContent arg on the tool.