Remove gen-docs make target #418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The target is broken - it is calling a gptscript that was deleted awhile ago. We probably do want a new version of gen-docs, but this isn't it. So, I'm deleting it for now. Signed-off-by: Craig Jellick <[email protected]>
drpebcak
approved these changes
Jun 3, 2024
Contributor
|
lol, I deleted that a while ago. So do we just not do docs? |
Contributor
Author
well, we def don't call gen-docs. I think ultimately we should re-introduce what we did with acorn and programatically generate docs for the cli flags and fail PRs if they get out of sync. Actually @drpebcak - could you add this to your stack of tasks? It all exists in acorn runtime, so should just be a matter of translating that to this project |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The target is broken - it is calling a gptscript that was deleted awhile
ago. We probably do want a new version of gen-docs, but this isn't it.
So, I'm deleting it for now.
Signed-off-by: Craig Jellick [email protected]