Skip to content

bug: only change user to system if there is just one message #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ibuildthecloud merged 1 commit into from
May 15, 2024
Merged

bug: only change user to system if there is just one message #357

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions pkg/openai/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,12 +238,9 @@ func toMessages(request types.CompletionRequest) (result []openai.ChatCompletion
})
}

// Never send only a system message or a system message not followed by a user message
if len(msgs) > 0 && msgs[0].Role == types.CompletionMessageRoleTypeSystem {
if len(msgs) == 1 ||
(len(msgs) > 1 && msgs[1].Role != types.CompletionMessageRoleTypeUser) {
msgs[0].Role = types.CompletionMessageRoleTypeUser
}
// Never send only a system message
if len(msgs) == 1 && msgs[0].Role == types.CompletionMessageRoleTypeSystem {
msgs[0].Role = types.CompletionMessageRoleTypeUser
}

for _, message := range msgs {
Expand Down