Skip to content

fix: do not lowercase all items in tool(like) lists #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cloudnautique merged 2 commits into from
May 14, 2024
Merged

fix: do not lowercase all items in tool(like) lists #344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
838b300
fix: do not lowercase all items in tool(like) lists
cloudnautique May 14, 2024
496fb38
fix: the tool name was not used in the prompt
cloudnautique May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pkg/chat/chat.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ func Start(ctx context.Context, prevState runner.ChatState, chatter Chatter, prg
}
defer prompter.Close()

// We will want the tool name to be displayed in the prompt
var prevResp runner.ChatResponse
for {
var (
input string
Expand All @@ -53,7 +55,7 @@ func Start(ctx context.Context, prevState runner.ChatState, chatter Chatter, prg
return err
}

prompter.SetPrompt(getPrompt(prg, resp))
prompter.SetPrompt(getPrompt(prg, prevResp))

if startInput != "" {
input = startInput
Expand All @@ -79,5 +81,6 @@ func Start(ctx context.Context, prevState runner.ChatState, chatter Chatter, prg
}

prevState = resp.State
prevResp = resp
}
}
10 changes: 5 additions & 5 deletions pkg/parser/parser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,15 +101,15 @@ func isParam(line string, tool *types.Tool) (_ bool, err error) {
}
tool.Parameters.Chat = v
case "export":
tool.Parameters.Export = append(tool.Parameters.Export, csv(strings.ToLower(value))...)
tool.Parameters.Export = append(tool.Parameters.Export, csv(value)...)
case "tool", "tools":
tool.Parameters.Tools = append(tool.Parameters.Tools, csv(strings.ToLower(value))...)
tool.Parameters.Tools = append(tool.Parameters.Tools, csv(value)...)
case "globaltool", "globaltools":
tool.Parameters.GlobalTools = append(tool.Parameters.GlobalTools, csv(strings.ToLower(value))...)
tool.Parameters.GlobalTools = append(tool.Parameters.GlobalTools, csv(value)...)
case "exportcontext":
tool.Parameters.ExportContext = append(tool.Parameters.ExportContext, csv(strings.ToLower(value))...)
tool.Parameters.ExportContext = append(tool.Parameters.ExportContext, csv(value)...)
case "context":
tool.Parameters.Context = append(tool.Parameters.Context, csv(strings.ToLower(value))...)
tool.Parameters.Context = append(tool.Parameters.Context, csv(value)...)
case "args", "arg", "param", "params", "parameters", "parameter":
if err := addArg(value, tool); err != nil {
return false, err
Expand Down
2 changes: 1 addition & 1 deletion pkg/tests/testdata/TestCase/call1.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
{
"function": {
"toolID": "testdata/TestCase/test.gpt:6",
"name": "bob",
"name": "Bob",
"description": "I'm Bob, a friendly guy.",
"parameters": {
"properties": {
Expand Down
2 changes: 1 addition & 1 deletion pkg/tests/testdata/TestCase2/call1.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
{
"function": {
"toolID": "testdata/TestCase2/test.gpt:6",
"name": "bob",
"name": "Bob",
"description": "I'm Bob, a friendly guy.",
"parameters": {
"properties": {
Expand Down