Skip to content

bug: sys.chat.finish did not return proper message #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ibuildthecloud merged 1 commit into from
May 6, 2024
Merged

bug: sys.chat.finish did not return proper message #322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/builtin/builtin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,7 +630,7 @@ func (e *ErrChatFinish) Error() string {

func SysChatFinish(ctx context.Context, env []string, input string) (string, error) {
var params struct {
Message string `json:"message,omitempty"`
Message string `json:"summary,omitempty"`
}
if err := json.Unmarshal([]byte(input), &params); err != nil {
return "", &ErrChatFinish{
Expand Down
4 changes: 2 additions & 2 deletions pkg/tests/runner_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ func TestDualSubChat(t *testing.T) {
r.RespondWith(tester.Result{
Func: types.CompletionFunctionCall{
Name: types.ToolNormalizer("sys.chat.finish"),
Arguments: `{"message":"Chat done"}`,
Arguments: `{"summary":"Chat done"}`,
},
})

Expand All @@ -89,7 +89,7 @@ func TestDualSubChat(t *testing.T) {
r.RespondWith(tester.Result{
Func: types.CompletionFunctionCall{
Name: types.ToolNormalizer("sys.chat.finish"),
Arguments: `{"message":"Chat done2"}`,
Arguments: `{"summary":"Chat done2"}`,
},
}, tester.Result{
Text: "And we're done",
Expand Down