Skip to content

fix: do not store empty credentials #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
g-linville merged 1 commit into from
Apr 17, 2024
Merged

fix: do not store empty credentials #254

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions pkg/runner/runner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,9 +384,19 @@ func (r *Runner) handleCredentials(callCtx engine.Context, monitor Monitor, env
Env: envMap.Env,
}

// Only store the credential if the tool is on GitHub.
isEmpty := true
for _, v := range cred.Env {
if v != "" {
isEmpty = false
break
}
}

// Only store the credential if the tool is on GitHub, and the credential is non-empty.
if isGitHubTool(credToolName) && callCtx.Program.ToolSet[credToolID].Source.Repo != nil {
if err := store.Add(*cred); err != nil {
if isEmpty {
log.Warnf("Not saving empty credential for tool %s", credToolName)
} else if err := store.Add(*cred); err != nil {
return nil, fmt.Errorf("failed to add credential for tool %s: %w", credToolName, err)
}
} else {
Expand Down