Skip to content

fix: The traces don't cleaned when calling Log.Info after Log.Error#473

Merged
krishankumar01 merged 1 commit intov1.13.xfrom
kkumar-gcc/#402-fix
Apr 30, 2024
Merged

fix: The traces don't cleaned when calling Log.Info after Log.Error#473
krishankumar01 merged 1 commit intov1.13.xfrom
kkumar-gcc/#402-fix

Conversation

@krishankumar01
Copy link
Member

@krishankumar01 krishankumar01 commented Apr 30, 2024 •
edited
Loading

Closes goravel/goravel#402

📑 Description

image
image

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@krishankumar01 krishankumar01 requested a review from a team April 30, 2024 08:52
devhaozi
devhaozi approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@devhaozi devhaozi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.10%. Comparing base (ad61d31) to head (d4701cf).
Report is 101 commits behind head on v1.13.x.

Additional details and impacted files 
@@             Coverage Diff              @@
##           v1.13.x     #473       +/-   ##
============================================
- Coverage    62.24%   45.10%   -17.15%     
============================================
  Files          125      232      +107     
  Lines         8078    17308     +9230     
============================================
+ Hits          5028     7806     +2778     
- Misses        2717     8953     +6236     
- Partials       333      549      +216

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krishankumar01 krishankumar01 merged commit d14ec3a into v1.13.x Apr 30, 2024
@krishankumar01 krishankumar01 deleted the kkumar-gcc/#402-fix branch April 30, 2024 09:35
hwbrzzl added a commit that referenced this pull request Dec 20, 2024
@hwbrzzl
feat: [#473] ORM has its own logger instead of using facades.Log()
fabc873
@coderabbitai coderabbitai bot mentioned this pull request Dec 20, 2024
Merged
1 task
hwbrzzl added a commit that referenced this pull request Dec 20, 2024
@hwbrzzl
Merge branch 'master' into bowen/#473
444f72e
hwbrzzl added a commit that referenced this pull request Dec 21, 2024
@hwbrzzl
feat: [#473] ORM has its own logger instead of using facades.Log() (#781
9b776be 
)

* feat: [#473] ORM has its own logger instead of using facades.Log()

* fix test

* fix test

* remove with

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devhaozi devhaozi devhaozi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@krishankumar01 @devhaozi