feat: command - handle argument errors via onUsageError()#1208
Merged
hwbrzzl merged 2 commits intogoravel:masterfrom Oct 22, 2025
Merged
feat: command - handle argument errors via onUsageError()#1208hwbrzzl merged 2 commits intogoravel:masterfrom
hwbrzzl merged 2 commits intogoravel:masterfrom
Conversation
b1c3c10 to
0ce129c
Compare
- [Release notes](https://github.com/urfave/cli/releases/tag/v3.5.0) - [Commits](urfave/cli@v3.4.1...v3.5.0) - sync with default value update
0ce129c to
6bfd234
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1208 +/- ##
==========================================
+ Coverage 65.73% 65.75% +0.02%
==========================================
Files 248 248
Lines 17185 17205 +20
==========================================
+ Hits 11297 11314 +17
- Misses 5511 5513 +2
- Partials 377 378 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hwbrzzl
approved these changes
Oct 22, 2025
Contributor
hwbrzzl
left a comment
There was a problem hiding this comment.
Thanks, LGTM. And I wonder if you have any ideas on this PR, given you are familiar with the urfave/cli package. Basically, urfave/cli doesn't support concurrency, we want to solve it in Goravel. We may optimize the Goravel logic or need to modify a urfave/cli fork directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
✅ Checks