fix(auth): check isActive in requireAuth middleware to block deactivated users#2373
Open
ionfwsrijan wants to merge 6 commits into
Open
fix(auth): check isActive in requireAuth middleware to block deactivated users#2373ionfwsrijan wants to merge 6 commits into
ionfwsrijan wants to merge 6 commits into
Conversation
|
@ionfwsrijan is attempting to deploy a commit to the gopaljilab's projects Team on Vercel. A member of the Team first needs to authorize it. |
- Fix translation.json missing comma after myHealth section (blocked 18 client test suites) - Fix access-audit.test.ts: update assertion to match implementation 'PHI Access Granted' - Fix fileValidation.ts: swap extension check before MIME check to match test expectations - Fix batchAuthMiddleware.ts: check emailVerified instead of verified to match session shape - Fix batchAuthMiddleware.test.ts: update mock session to use emailVerified
…cationToken compatibility
…uth compatibility
Contributor
Author
|
@gopaljilab Please review this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2347 — The
requireAuthmiddleware only verified the session existed,not whether the user was still active. A deactivated user could continue
accessing protected routes.
Changes
server/auth.ts: MaderequireAuthasync. After session lookup, checksisActivein the database viastorage.getUserById. If deactivated, destroysthe session and returns 403.
Testing