-
Notifications
You must be signed in to change notification settings - Fork 85
Closed
Labels
api: firestoreIssues related to the googleapis/python-firestore API.Issues related to the googleapis/python-firestore API.priority: p3Desirable enhancement or fix. May not be included in next release.Desirable enhancement or fix. May not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Milestone
Description
Currently, mypy is just testing the google.cloud.firestore module, which is mostly empty. If changed to test google.cloud.firestore_v1, errors come up. We should resolve all typing issues with the library
One option is to completely wipe the type annotations and start fresh, slowly adding them back over time
Or, we can fix it one file at a time, as we touch different areas of the code
cbenhagen
Metadata
Metadata
Assignees
Labels
api: firestoreIssues related to the googleapis/python-firestore API.Issues related to the googleapis/python-firestore API.priority: p3Desirable enhancement or fix. May not be included in next release.Desirable enhancement or fix. May not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.